Bug with Bulletproof links

[n2ition]

I apologize if this is a repeat question but I thought I did a thorough search before posting.

I am running s9y 1.6 with the bulletproof template. I am just setting the blog up and for some reason the navbar links are not allowing changes. I changed them from the default number 5 to 2. The first is named Home and obviously links to the main page. However the second link gets named Submit a Story and is linked to a custom contact page. I put in the correct URL in and hit save. The manage styles page reloads and the link is correct but the link name has been reverted back to the default (Link #2). If site is previewed the label is wrong put it does link to the correct page. However, if another attempt is made to put the correct link title in and save is selected both the title AND the URL revert back to the default info. (link #2 and # respectively).

I have been off the blogosphere for about 5 years but when this new project came up I knew that s9y was exactly what I needed as past experience with the product has been exceptional. I look forward to any help folks can provide.

Thanks in advance!

[yellowled]

I put in the correct URL in and hit save. The manage styles page reloads and the link is correct but the link name has been reverted back to the default (Link #2). If site is previewed the label is wrong put it does link to the correct page. However, if another attempt is made to put the correct link title in and save is selected both the title AND the URL revert back to the default info. (link #2 and # respectively).

Garvin, this sounds like the known bug with the global nav which was supposed to be fixed?

YL

[garvinhicking]

Hi!

Hm, that really sounds odd and should have been fixed. Would you be able to provide me access to your s9y blog with the URL and a s9y account as well as temporary FTP or SSH access to edit the s9y files? then I could debug this easier...if so, please send me a PM.

Regards,
Garvin

[garvinhicking]

Hi!

thanks to n2ition for being so kind to supply me with details to inspect the situation.

I was able to find the problem and commit a fix for a new s9y version. Now the reason is as follows.

Serendipity 1.6 introduced a new global navigation, so that navigation links and descriptions could be used across multiple templates. For this distiction there's a "serendipity_options" database table where each configuration key and value are stored together with a prefix that's bound to the template.

In the past, each bulletproof config item hat the prefix "t_bulletproof". Now, global values are stored as "t_global". Sadly, once you have old bulletproof config values in there, with the new s9y 1.6 code the values get read by a random order and thus, you can only write "t_global" variables and not ever change the "t_bulletproof" ones again.

What I've done to remedy this is to now always clean up the old identically named t_bulletproof config variables that are now global.

In MySQL this could also be done easily with this query:

Code: Select all

DELETE FROM serendipity_options WHERE okey = "t_bulletproof" AND name LIKE "navlink%"

This erases all old-style variables and only keep the "t_global" ones. Of course, the easier solution is to download this file and replace it over your s9y installation:

https://raw.github.com/s9y/Serendipity/ ... es.inc.php

(Note, n2ition: I've already applied this patch for you)

[yellowled]

Of course, the easier solution is to download this file and replace it over your s9y installation:

https://raw.github.com/s9y/Serendipity/ ... es.inc.php

Just to make this 100% understandable: this is supposed to overwrite the existing include/admin/templates.inc.php of any given 1.6 installation and there's no need to do anything else, right?

YL

[garvinhicking]

Hi!

Right.

[n2ition]

Garvin,

Once again you are my hero! Thank you, thank you, thank you!

Heather